Bug 18659 - Barcode input filter not taken into consideration with batch
Summary: Barcode input filter not taken into consideration with batch
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Blou
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-23 15:02 UTC by Blou
Modified: 2017-12-07 22:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blou 2017-05-23 15:02:55 UTC
circulation.pl was modified to handle barcode batches, but the code modifying the barcode is isolated and does not modify the batch.

for my $barcode ( @$barcodes ) { 
    $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace
    $barcode = barcodedecode($barcode)
        if( $barcode && C4::Context->preference('itemBarcodeInputFilter'));
}

The local $barcode is modified, but not the array content.  The issuing code later on just start with @$barcodes again, not with $barcode, so the modif is not even considered when using one barcode.
Comment 1 Blou 2017-05-23 15:11:51 UTC
Ok, this is a code 18.  In normal circumstances (code not modified), would not happen.  Code is ok. 
I would close it if I could, but can't.  So here, Resolved-Invalid.  Hope it's ok.