Summary: | Fix ungrammatical sentence | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | System Administration | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, m.de.rooy, mtj, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Minor grammar correction
Revised to incorporate Marc's suggestion Bug 18700 Fix grammar (data cannot be pluralized) Bug 18700 Fix grammar (data cannot be pluralized) |
Description
Colin Campbell
2017-05-30 14:17:07 UTC
Created attachment 63848 [details] [review] Minor grammar correction Fix the grammar of the sentence removing the incorrect pluralization of data - switch those to these to improve flow - I expect to test find a pedantic grammarian and see if the still wince at the sentence after the patch is applied Tiny proposal from a non native speaker: --- Define the mapping between keywords and MARC fields. The keywords are used to find some data independently of the framework. --- Splitting the message into two sentences (one for the fact, one for the explanation) would improve translatability a little bit. Created attachment 63858 [details] [review] Revised to incorporate Marc's suggestion Marc's suggestion improves the text Created attachment 63860 [details] [review] Bug 18700 Fix grammar (data cannot be pluralized) data is a mass noun or plural of datum - datas is ungrammatical and jarring for a native speaker. Split the awkward sounding sentence into two for more clarity, thanks to Marc Véron for the suggestion. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 63921 [details] [review] Bug 18700 Fix grammar (data cannot be pluralized) data is a mass noun or plural of datum - datas is ungrammatical and jarring for a native speaker. Split the awkward sounding sentence into two for more clarity, thanks to Marc Véron for the suggestion. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |