Bug 18738

Summary:	Koha_Elasticsearch_Indexer.t fails if Elasticsearch is configured but not running
Product:	Koha	Reporter:	Lee Jamison <ldjamison>
Component:	Test Suite	Assignee:	Mark Tompsett <mtompset>
Status:	CLOSED INVALID	QA Contact:	Galen Charlton <gmcharlt>
Severity:	minor
Priority:	P5 - low	CC:	black23, hayleypelham, jonathan.druart, mtj, mtompset, tomascohen
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20576 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 18738: Improve failure cases to skip better Bug 18738: Improve failure cases to skip better

Description Lee Jamison 2017-06-06 16:08:49 UTC

When Elasticsearch is not configured/not running, executing

prove -v t/db_dependent/Koha_Elasticsearch_Indexer.t

fails with the same error message as indicated in Bug 12478

([NoNodes] ** No nodes are available: [http://localhost:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.10.1/Catmandu/Store/ElasticSearch.pm line 61)

Leaving the Elasticsearch koha-conf values empty creates same failure.

Comment 1 Mark Tompsett 2018-04-12 19:38:53 UTC Comment hidden (obsolete)

Created attachment 74118 [details] [review]
Bug 18738: Improve failure cases to skip better

TEST PLAN
---------
no elasticsearch section in koha-conf.xml
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- nasty
elasticsearch, but no nodes
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- ugly
apply patch
re-run above cases
-- unique skips
run qa test tools

Comment 2 Mark Tompsett 2018-04-13 02:31:00 UTC

Created attachment 74121 [details] [review]
Bug 18738: Improve failure cases to skip better

TEST PLAN
---------
no elasticsearch section in koha-conf.xml
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- nasty
elasticsearch, but no nodes
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- ugly
apply patch
re-run above cases
-- unique skips
run qa test tools

Comment 3 Hayley Pelham 2019-03-08 02:39:14 UTC

Patch doesn't apply

Applying: Bug 18738: Improve failure cases to skip better
Using index info to reconstruct a base tree...
A	t/db_dependent/Koha_Elasticsearch_Indexer.t
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): t/db_dependent/Koha_Elasticsearch_Indexer.t deleted in HEAD and modified in Bug 18738: Improve failure cases to skip better. Version Bug 18738: Improve failure cases to skip better of t/db_dependent/Koha_Elasticsearch_Indexer.t left in tree.
error: Failed to merge in the changes.
Patch failed at 0001 Bug 18738: Improve failure cases to skip better

Comment 4 Katrin Fischer 2019-03-08 06:54:17 UTC

Hi Hayley, if a patch doesn't apply, you can use the status "Patch doesn't apply" . Thx for your testing!

Comment 5 Michal Denar 2019-07-09 20:17:06 UTC

Hi,
can author rebase this on master, please?

Thank you.

Comment 6 Katrin Fischer 2023-09-15 21:49:41 UTC

Test file Koha_Elasticsearch_Indexer.t no longer exists.