Summary: | xt/sample notices fails with "No sample notice to delete" | ||
---|---|---|---|
Product: | Koha | Reporter: | Lee Jamison <ldjamison> |
Component: | Test Suite | Assignee: | Lee Jamison <ldjamison> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 17855 | ||
Bug Blocks: | |||
Attachments: |
Bug 18749 - xt/sample_notices.t fails
[SIGNED-OFF] Bug 18749 - xt/sample_notices.t fails Bug 18749 - xt/sample_notices.t fails |
Description
Lee Jamison
2017-06-07 17:27:40 UTC
Created attachment 64086 [details] [review] Bug 18749 - xt/sample_notices.t fails Bug Description: When performing a unit test on xt/sample_notices.t with the command 'prove xt/sample_notices.t' 11 tests fail with the error message "No sample notice to delete". Cause of bug: The failures are caused by an incorrect file path on Line 25 of xt/sample_notices.t. Patch Description: This patch corrects the failures by changing $base_notices_file from "en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql" Test Plan: 1) Drop into koha-shell and run the command 'prove xt/sample_notices.' 2) 11 unit tests fail. 3) Apply the patch. 4) Re-run 'prove xt/sample_notices.t' 5) All of the tests pass now. 6) Quit out of koha-shell Created attachment 64180 [details] [review] [SIGNED-OFF] Bug 18749 - xt/sample_notices.t fails Bug Description: When performing a unit test on xt/sample_notices.t with the command 'prove xt/sample_notices.t' 11 tests fail with the error message "No sample notice to delete". Cause of bug: The failures are caused by an incorrect file path on Line 25 of xt/sample_notices.t. Patch Description: This patch corrects the failures by changing $base_notices_file from "en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql" Test Plan: 1) Drop into koha-shell and run the command 'prove xt/sample_notices.' 2) 11 unit tests fail. 3) Apply the patch. 4) Re-run 'prove xt/sample_notices.t' 5) All of the tests pass now. 6) Quit out of koha-shell Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 64262 [details] [review] Bug 18749 - xt/sample_notices.t fails Bug Description: When performing a unit test on xt/sample_notices.t with the command 'prove xt/sample_notices.t' 11 tests fail with the error message "No sample notice to delete". Cause of bug: The failures are caused by an incorrect file path on Line 25 of xt/sample_notices.t. Patch Description: This patch corrects the failures by changing $base_notices_file from "en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql" Test Plan: 1) Drop into koha-shell and run the command 'prove xt/sample_notices.' 2) 11 unit tests fail. 3) Apply the patch. 4) Re-run 'prove xt/sample_notices.t' 5) All of the tests pass now. 6) Quit out of koha-shell Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 Depends on onboarding feature which is not in 16.11.x. |