Bug 18798

Summary: Use Koha.Preference in OPAC Reading Record
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: OPACAssignee: Aleisha Amohia <aleisha>
Status: BLOCKED --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: amitddng135, jonathan.druart, m.de.rooy
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17896    
Bug Blocks:    
Attachments: Bug 18798: Use Koha.Preference in OPAC Reading Record
Bug 18798: Use Koha.Preference in OPAC Reading Record
[SIGNED-OFF] Bug 18798: Use Koha.Preference in OPAC Reading Record
Bug 18798: Use Koha.Preference in OPAC Reading Record
Bug 18798: (follow-up) Use Koha.preference for GoogleJackets
Bug 18798: (follow-up) Use Koha.preference for GoogleJackets

Description Aleisha Amohia 2017-06-13 21:57:40 UTC
Should not be passing the preference from the pl file - can check the preference using template plugin Koha.Preference
Comment 1 Aleisha Amohia 2017-06-13 22:20:05 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2017-06-13 22:21:29 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2017-08-14 12:51:25 UTC
Created attachment 65955 [details] [review]
[SIGNED-OFF] Bug 18798: Use Koha.Preference in OPAC Reading Record

This patch uses the Koha.Preference plugin method for the following
sysprefs:
 - OPACMySummaryHTML
 - OPACAmazonCoverImages
 - SyndeticsEnabled
 - SyndeticsCoverImages
 - SyndeticsClientCode
 - GoogleJackets
 - BakerTaylorEnabled (Bug 17896)
 - BakerTaylorBookstoreURL (Bug 17896)

To test, apply the patch from Bug 17896 and confirm that enabling and
disabling the above sysprefs does not break anything.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I'm not able to test Syndetics and BakerTaylor, but everything else
works correctly.
Comment 4 Marcel de Rooy 2017-11-03 10:48:30 UTC
[% IF GoogleJackets %]

Forgotten ?
Comment 5 Owen Leonard 2018-12-07 17:53:06 UTC
Created attachment 82992 [details] [review]
Bug 18798: Use Koha.Preference in OPAC Reading Record

This patch uses the Koha.Preference plugin method for the following
sysprefs:
 - OPACMySummaryHTML
 - OPACAmazonCoverImages
 - SyndeticsEnabled
 - SyndeticsCoverImages
 - SyndeticsClientCode
 - GoogleJackets
 - BakerTaylorEnabled (Bug 17896)
 - BakerTaylorBookstoreURL (Bug 17896)

To test, apply the patch from Bug 17896 and confirm that enabling and
disabling the above sysprefs does not break anything.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I'm not able to test Syndetics and BakerTaylor, but everything else
works correctly.
Comment 6 Owen Leonard 2018-12-07 18:40:07 UTC
Created attachment 82994 [details] [review]
Bug 18798: (follow-up) Use Koha.preference for GoogleJackets

This patch converts the check for the GoogleJackets preference to use
the Koha.preference() style.

To test, apply the patch and log in to the OPAC as a user who has a
checkout history. View the "your reading history" page with
GoogleJackets both enabled and disabled. Everything should work
correctly.
Comment 7 Aleisha Amohia 2018-12-09 20:48:42 UTC
Created attachment 83003 [details] [review]
Bug 18798: (follow-up) Use Koha.preference for GoogleJackets

This patch converts the check for the GoogleJackets preference to use
the Koha.preference() style.

To test, apply the patch and log in to the OPAC as a user who has a
checkout history. View the "your reading history" page with
GoogleJackets both enabled and disabled. Everything should work
correctly.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 8 Jonathan Druart 2018-12-12 19:52:15 UTC
Blocked by bug 17896.