Summary: | Use Koha.Preference in OPAC Reading Record | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
Status: | BLOCKED --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | amitddng135, jonathan.druart, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17896 | ||
Bug Blocks: | |||
Attachments: |
Bug 18798: Use Koha.Preference in OPAC Reading Record
Bug 18798: Use Koha.Preference in OPAC Reading Record [SIGNED-OFF] Bug 18798: Use Koha.Preference in OPAC Reading Record Bug 18798: Use Koha.Preference in OPAC Reading Record Bug 18798: (follow-up) Use Koha.preference for GoogleJackets Bug 18798: (follow-up) Use Koha.preference for GoogleJackets |
Description
Aleisha Amohia
2017-06-13 21:57:40 UTC
Created attachment 64272 [details] [review] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17986) - BakerTaylorBookstoreURL (Bug 17986) To test, apply the patch from Bug 17986 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT Created attachment 64273 [details] [review] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17896) - BakerTaylorBookstoreURL (Bug 17896) To test, apply the patch from Bug 17896 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT Created attachment 65955 [details] [review] [SIGNED-OFF] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17896) - BakerTaylorBookstoreURL (Bug 17896) To test, apply the patch from Bug 17896 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I'm not able to test Syndetics and BakerTaylor, but everything else works correctly. [% IF GoogleJackets %] Forgotten ? Created attachment 82992 [details] [review] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17896) - BakerTaylorBookstoreURL (Bug 17896) To test, apply the patch from Bug 17896 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I'm not able to test Syndetics and BakerTaylor, but everything else works correctly. Created attachment 82994 [details] [review] Bug 18798: (follow-up) Use Koha.preference for GoogleJackets This patch converts the check for the GoogleJackets preference to use the Koha.preference() style. To test, apply the patch and log in to the OPAC as a user who has a checkout history. View the "your reading history" page with GoogleJackets both enabled and disabled. Everything should work correctly. Created attachment 83003 [details] [review] Bug 18798: (follow-up) Use Koha.preference for GoogleJackets This patch converts the check for the GoogleJackets preference to use the Koha.preference() style. To test, apply the patch and log in to the OPAC as a user who has a checkout history. View the "your reading history" page with GoogleJackets both enabled and disabled. Everything should work correctly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> |