Bug 18806

Summary: Cannot revert a batch
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ToolsAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to Master --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: major    
Priority: P5 - low CC: m.de.rooy
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329
Whiteboard:
Change sponsored?: --- Patch complexity: Small patch
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Bug Depends on: 18242    
Bug Blocks: 18807    
Attachments: Bug 18806: Fix batch revert
Bug 18806: Fix batch revert
Bug 18806: Fix batch revert

Description Jonathan Druart 2017-06-14 18:52:12 UTC
Since bug 18242: When a biblio is deleted, a new transaction is created.
tools/manage-marc-import.pl use the AutoCommit flag, which does not allow nested transaction.
AutoCommit must not be used.
Comment 1 Jonathan Druart 2017-06-14 18:54:30 UTC
Created attachment 64298 [details] [review]
Bug 18806: Fix batch revert

Since bug 18242: When a biblio is deleted, a new transaction is created.
tools/manage-marc-import.pl use the AutoCommit flag, which does not
allow nested transaction.
AutoCommit must not be used.

Test plan:
Import a batch, then revert it.
The biblios must have been correctly deleted, they were not before this
patch
Comment 2 Lee Jamison 2017-06-15 22:38:01 UTC
Created attachment 64371 [details] [review]
Bug 18806: Fix batch revert

Since bug 18242: When a biblio is deleted, a new transaction is created.
tools/manage-marc-import.pl use the AutoCommit flag, which does not
allow nested transaction.
AutoCommit must not be used.

Test plan:
Import a batch, then revert it.
The biblios must have been correctly deleted, they were not before this
patch

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Comment 3 Marcel de Rooy 2017-06-16 07:33:44 UTC
QA: Looking here now
Comment 4 Marcel de Rooy 2017-06-16 07:54:34 UTC
Created attachment 64377 [details] [review]
Bug 18806: Fix batch revert

Since bug 18242: When a biblio is deleted, a new transaction is created.
tools/manage-marc-import.pl use the AutoCommit flag, which does not
allow nested transaction.
AutoCommit must not be used.

Test plan:
Import a batch, then revert it.
The biblios must have been correctly deleted, they were not before this
patch

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2017-06-19 19:38:56 UTC
Pushed to master for 17.11, thanks to everybody involved!