|
Description
Alex Sassmannshausen
2017-06-21 14:44:04 UTC
Created attachment 66628 [details] [review] Add ILL Unmediated syspref stuff. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Created attachment 66629 [details] [review] Introduce delegation to backends for unmediated workflows. * Koha/Illrequest.pm (backend_create): Add dispatch. Created attachment 74874 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Created attachment 74875 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Hi Andrew, please always make sure to include a test plan. Hi Katrin Thanks for the reminder. I'd not added test plans because these patches were simply direct replacements for Alex's, which had become impossible to apply. The work on this bug is incomplete so there's a good chance these patches will be obsoleted as I complete the work. I figured it was probably OK to not include test plans yet as no-one would be trying to test it as it's not yet in "Needs signoff", and won't be until the work is complete. Hope that's OK. Andrew Ah sure, I missed ASSIGNED the status! To test: - Apply patches - Ensure ILL is enabled and you have at least one backend available that supports unmediated requests (currently only the BLDSS backend supports this) - Enable "ILLModuleUnmediated" preference - As an OPAC user, navigate to "Your summary" > "Your interlibrary loan requests" - Select "Create a new request" > "BLDSS" - Search for an item and create an interlibrary loan request - Observe that in the "Your interlibrary loan requests" view, the request now has the status of "Requested" rather than the "New request" status that it would have in an mediated workflow. Created attachment 79542 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Created attachment 79543 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Hertfordshire University have undertaken lots of testing upon this work and have been running it in production for some time now. They have asked me to sign it off on their behalf.. I have added their testing team to the patches signoff lines. Thanks guys :) Created attachment 82158 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Created attachment 82159 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Rebased on top of current dependency tree Created attachment 82508 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Created attachment 82509 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Could you rebase please? Created attachment 86188 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Created attachment 86189 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> To test:
- Apply patches
- Ensure ILL is enabled and you have at least one backend available that supports unmediated requests (currently only the BLDSS backend supports this)
- Enable "ILLModuleUnmediated" preference
- Ensure you have default delivery formats specified in your koha-conf.xml. These should be placed inside the <interlibrary_loans> block, an example (which specifies the loan should be a paper copy, of standard quality, delivered within 4 days) is below:
<default_formats>
<format>4</format>
<speed>4</speed>
<quality>1</quality>
</default_formats>
- As an OPAC user, navigate to "Your summary" > "Your interlibrary loan requests"
- Select "Create a new request" > "BLDSS"
- Search for an item and create an interlibrary loan request
=> TEST: Observe that in the "Your interlibrary loan requests" view, the request now has the status of "Requested" rather than the "New request" status that it would have in an mediated workflow.
When the library has missing some data it is shown like this: https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost But when is missing country, it dies in BLDSS/Base.pm, (but request is still created with status "New") not sure if we could do something with this in Koha... Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update and also not used in code, so probably should be removed When I have all address data OK, I got this message: "Invalid Request: At least one Item Of Interest level piece of metadata is required." Is it possible to show which metadata is missing? Created attachment 86236 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Created attachment 86237 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> (In reply to Josef Moravec from comment #21) > When the library has missing some data it is shown like this: > https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost > > But when is missing country, it dies in BLDSS/Base.pm, (but request is still > created with status "New") not sure if we could do something with this in > Koha... Yes, I'll create a bug report on the BLDSS Github site so we can get it fixed. > Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update > and also not used in code, so probably should be removed Updated patches attached > When I have all address data OK, I got this message: "Invalid Request: At > least one Item Of Interest level piece of metadata is required." > Is it possible to show which metadata is missing? Sadly not, that error is coming back from the BLDSS service, it's not very helpful, I agree! :( (In reply to Andrew Isherwood from comment #24) > (In reply to Josef Moravec from comment #21) > > When the library has missing some data it is shown like this: > > https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost > > > > But when is missing country, it dies in BLDSS/Base.pm, (but request is still > > created with status "New") not sure if we could do something with this in > > Koha... > > Yes, I'll create a bug report on the BLDSS Github site so we can get it > fixed. > > > Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update > > and also not used in code, so probably should be removed > > Updated patches attached > > > When I have all address data OK, I got this message: "Invalid Request: At > > least one Item Of Interest level piece of metadata is required." > > Is it possible to show which metadata is missing? > > Sadly not, that error is coming back from the BLDSS service, it's not very > helpful, I agree! :( Thanks for answers and quick rebase! I am continuing here... Created attachment 86238 [details] [review] Bug 18837: (QA follow-up) Update system preference desciprition Created attachment 86371 [details] [review] Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled Created attachment 86372 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Created attachment 86373 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Created attachment 86374 [details] [review] Bug 18837: (QA follow-up) Update system preference desciprition Created attachment 86375 [details] [review] Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled Created attachment 86422 [details] [review] Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86423 [details] [review] Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86424 [details] [review] Bug 18837: (QA follow-up) Update system preference desciprition Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86425 [details] [review] Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86426 [details] [review] Bug 18837: (QA follow-up) Fix order of sysprefa.sql Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |