Bug 21063 - Allow columns in intranet ILL request datatable to be customisable
Summary: Allow columns in intranet ILL request datatable to be customisable
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Andrew Isherwood
QA Contact:
URL:
Whiteboard:
Keywords:
: 20883 (view as bug list)
Depends on: 20750
Blocks: 18837
  Show dependency treegraph
 
Reported: 2018-07-12 09:22 UTC by Andrew Isherwood
Modified: 2018-11-19 14:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 21063: Add "Columns settings" for ILL (2.76 KB, patch)
2018-07-13 10:16 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add ability to show / hide columns (12.50 KB, patch)
2018-07-13 10:16 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add "Columns settings" for ILL (2.76 KB, patch)
2018-07-13 10:33 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add ability to show / hide columns (12.50 KB, patch)
2018-07-13 10:34 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add "Columns settings" for ILL (2.81 KB, patch)
2018-09-28 07:18 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 21063: Add ability to show / hide columns (12.59 KB, patch)
2018-09-28 07:18 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 21063: Add "Columns settings" for ILL (2.84 KB, patch)
2018-10-17 09:11 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add ability to show / hide columns (12.46 KB, patch)
2018-10-17 09:11 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: (follow-up) Fix bad merge (1.52 KB, patch)
2018-10-18 10:59 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: (follow-up) Add user ID to column list (2.74 KB, patch)
2018-10-18 13:35 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add "Columns settings" for ILL (2.84 KB, patch)
2018-11-09 10:52 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add ability to show / hide columns (14.30 KB, patch)
2018-11-09 10:52 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: (follow-up) Add user ID to column list (3.02 KB, patch)
2018-11-09 10:52 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: (follow-up) Amendments for rebase (12.08 KB, patch)
2018-11-09 10:52 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add "Columns settings" for ILL (2.84 KB, patch)
2018-11-19 14:30 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: Add ability to show / hide columns (14.30 KB, patch)
2018-11-19 14:30 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: (follow-up) Add user ID to column list (3.02 KB, patch)
2018-11-19 14:30 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21063: (follow-up) Amendments for rebase (10.93 KB, patch)
2018-11-19 14:30 UTC, Andrew Isherwood
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Isherwood 2018-07-12 09:22:02 UTC
Currently the columns in this datatable are static, they should be customisable.
Comment 1 Andrew Isherwood 2018-07-13 10:16:11 UTC Comment hidden (obsolete)
Comment 2 Andrew Isherwood 2018-07-13 10:16:23 UTC Comment hidden (obsolete)
Comment 3 Andrew Isherwood 2018-07-13 10:33:53 UTC Comment hidden (obsolete)
Comment 4 Andrew Isherwood 2018-07-13 10:34:05 UTC Comment hidden (obsolete)
Comment 5 PTFS Europe Sandboxes 2018-09-28 07:18:24 UTC Comment hidden (obsolete)
Comment 6 PTFS Europe Sandboxes 2018-09-28 07:18:47 UTC Comment hidden (obsolete)
Comment 7 Andrew Isherwood 2018-10-17 09:11:19 UTC Comment hidden (obsolete)
Comment 8 Andrew Isherwood 2018-10-17 09:11:23 UTC Comment hidden (obsolete)
Comment 9 Andrew Isherwood 2018-10-17 09:11:50 UTC
Rebased on master
Comment 10 Andrew Isherwood 2018-10-18 10:59:32 UTC Comment hidden (obsolete)
Comment 11 Andrew Isherwood 2018-10-18 13:35:19 UTC Comment hidden (obsolete)
Comment 12 Andrew Isherwood 2018-10-18 13:38:33 UTC
*** Bug 20883 has been marked as a duplicate of this bug. ***
Comment 13 Andrew Isherwood 2018-11-09 10:52:15 UTC Comment hidden (obsolete)
Comment 14 Andrew Isherwood 2018-11-09 10:52:25 UTC Comment hidden (obsolete)
Comment 15 Andrew Isherwood 2018-11-09 10:52:29 UTC Comment hidden (obsolete)
Comment 16 Andrew Isherwood 2018-11-09 10:52:32 UTC Comment hidden (obsolete)
Comment 17 Andrew Isherwood 2018-11-09 10:52:36 UTC Comment hidden (obsolete)
Comment 18 Andrew Isherwood 2018-11-09 10:53:24 UTC
Rebased on top of dependency tree
Comment 19 Andrew Isherwood 2018-11-19 14:30:33 UTC
Created attachment 82504 [details] [review]
Bug 21063: Add "Columns settings" for ILL

This patch adds the "Columns settings" values for the illrequests table

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
Comment 20 Andrew Isherwood 2018-11-19 14:30:37 UTC
Created attachment 82505 [details] [review]
Bug 21063: Add ability to show / hide columns

This patch adds the "Column visibility" functionality to the main ILL
request list table.

To test:
- Ensure ILL is enabled and you have some requests
- Apply patch
- From the "Koha administration screen, select "Configure columns"
- In the "Columns settings" page:
  => TEST: Ensure an "Interlibrary loans" category exists
  - Upon expanding the category:
  => TEST: Ensure a table is displayed showing columns
  => TEST: Ensure the "action" column has "Cannot be toggled"
  pre-selected
  => TEST: Change values for columns and ensure they're saved
- From the main staff menu, select "ILL requests"
- In the table:
  => TEST: Click the "Column visibility" button and ensure a modal
  containing all columns (except "Action")  is displayed
  => TEST: Select various columns and ensure they are shown and hidden

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
Comment 21 Andrew Isherwood 2018-11-19 14:30:41 UTC
Created attachment 82506 [details] [review]
Bug 21063: (follow-up) Add user ID to column list

As originally specified in bug 20883, there is a requirement for some
users to be able to display the user ID (borrowernumber) in the UI.

This patch adds that ability to this bug, 20883 will be marked as a
duplicate of this one.
Comment 22 Andrew Isherwood 2018-11-19 14:30:45 UTC
Created attachment 82507 [details] [review]
Bug 21063: (follow-up) Amendments for rebase

Modify to add the additional changes required now we're rebasing on top
of the dependency tree. Includes adding additional columns (and changing
indexes for search/filter where appropriate)