Bug 18858

Summary: Warn when deleting a borrower debarment
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: PatronsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, mtj
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18858: Prevent warn when deleting a borrower debarment
Bug 18858: Prevent warn when deleting a borrower debarment

Description Aleisha Amohia 2017-06-27 01:41:11 UTC
Deleting a debarment causes this warn in the logs:
CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_mod_debarment_2epl line 36, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
Comment 1 Aleisha Amohia 2017-06-27 01:43:13 UTC
Created attachment 64665 [details] [review]
Bug 18858: Prevent warn when deleting a borrower debarment

To test:
1) Look at intranet log
2) Go to delete a debarment on a borrower
3) Notice warn
4) Apply patch
5) Add a new debarment
6) Delete this debarment
7) Notice warn is gone

Sponsored-by: Catalyst IT
Comment 2 Jonathan Druart 2017-07-13 21:24:07 UTC
Created attachment 65033 [details] [review]
Bug 18858: Prevent warn when deleting a borrower debarment

To test:
1) Look at intranet log
2) Go to delete a debarment on a borrower
3) Notice warn
4) Apply patch
5) Add a new debarment
6) Delete this debarment
7) Notice warn is gone

Sponsored-by: Catalyst IT

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2017-07-13 21:24:27 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2017-07-13 21:43:29 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin Somers 2017-07-18 12:56:12 UTC
Pushed to 17.05.x, will be in 17.05.02
Comment 6 Katrin Fischer 2017-07-19 21:15:50 UTC
This patch has been pushed to 16.11.x and will be in 16.11.10.
Comment 7 Mason James 2017-07-31 12:15:02 UTC
Pushed to 16.05.x, for 16.05.15 release