Summary: | When 'on-site checkout' was used, the 'Specify due date' should be emptied for next checkout unless OnSiteCheckoutAutoCheck | ||
---|---|---|---|
Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Component: | Circulation | Assignee: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, lucas, sophie.meynieux, thibaud.guillot, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36494, 36459 | ||
Attachments: |
Bug 18885: Specify due date behavior according to on-site checkbox
Bug 18885: Specify due date behavior according to on-site checkbox Bug 18885: Specify due date behavior according to on-site checkbox |
Description
Baptiste Wojtkowski (bwoj)
2017-06-30 09:41:16 UTC
I believe a part of this bug has been fixed by making the onsite checkbox behaviour configurable with OnSiteCheckoutAutoCheck. I'd describe the remaining bug like this: When the specified due date was set automatically by checking the on-site checkbox and the OnSiteCheckoutAutoCheck is set to not keep the checkbox checked for the next checkout, the date should be empty out as well. If we don't always keep the checkbox - we should not automatically keep the date either. Created attachment 158115 [details] [review] Bug 18885: Specify due date behavior according to on-site checkbox When a on-site checkout is performed a date is automatically added but if you unchecked the date remains. Even with OnSiteCheckoutAutoCheck syspref Test plan: 1) Do an on-site checkout by clicking on checkbox and see date added 2) Unchecked and see that the date remains on input 3) Do another test with OnSiteCheckoutAutoCheck enabled 4) Apply this patch and repeat actions Normally now its works correctly Created attachment 159585 [details] [review] Bug 18885: Specify due date behavior according to on-site checkbox When a on-site checkout is performed a date is automatically added but if you unchecked the date remains. Even with OnSiteCheckoutAutoCheck syspref Test plan: 1) Do an on-site checkout by clicking on checkbox and see date added 2) Unchecked and see that the date remains on input 3) Do another test with OnSiteCheckoutAutoCheck enabled 4) Apply this patch and repeat actions Normally now its works correctly Signed-off-by: tuxayo <victor@tuxayo.net> It work :) Created attachment 163692 [details] [review] Bug 18885: Specify due date behavior according to on-site checkbox When a on-site checkout is performed a date is automatically added but if you unchecked the date remains. Even with OnSiteCheckoutAutoCheck syspref Test plan: 1) Do an on-site checkout by clicking on checkbox and see date added 2) Unchecked and see that the date remains on input 3) Do another test with OnSiteCheckoutAutoCheck enabled 4) Apply this patch and repeat actions Normally now its works correctly Signed-off-by: tuxayo <victor@tuxayo.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Won't backport this to 23.05.x unless a fix for Bug 36459 is provided. (In reply to Lucas Gass from comment #9) > Won't backport this to 23.05.x unless a fix for Bug 36459 is provided. I provided a patch for Bug 36459 if anyone wants to test. |