When you perform an onsite checkout, the next checkout is pre-setted as follows: - Specify due date => today - Onsite checkout => not checked I don't think this is is a correct behaviour: according to me there are 3 solutions, but I don't know which is the best: - Maintaining "onsite checkout" checked - Don't change duedatespec in interface when onsite checout is clicked and process it in the intranet part - Remove the duedatespec on the new checkout page loading This part of the code is really hard for me since it were patched and re patched and I'm not sure of the expected behaviour of all lines, so I would like some expert opinion before coding a solution
Linked to Bug 10067 and Bug 16527
I believe a part of this bug has been fixed by making the onsite checkbox behaviour configurable with OnSiteCheckoutAutoCheck. I'd describe the remaining bug like this: When the specified due date was set automatically by checking the on-site checkbox and the OnSiteCheckoutAutoCheck is set to not keep the checkbox checked for the next checkout, the date should be empty out as well. If we don't always keep the checkbox - we should not automatically keep the date either.
Created attachment 158115 [details] [review] Bug 18885: Specify due date behavior according to on-site checkbox When a on-site checkout is performed a date is automatically added but if you unchecked the date remains. Even with OnSiteCheckoutAutoCheck syspref Test plan: 1) Do an on-site checkout by clicking on checkbox and see date added 2) Unchecked and see that the date remains on input 3) Do another test with OnSiteCheckoutAutoCheck enabled 4) Apply this patch and repeat actions Normally now its works correctly
Created attachment 159585 [details] [review] Bug 18885: Specify due date behavior according to on-site checkbox When a on-site checkout is performed a date is automatically added but if you unchecked the date remains. Even with OnSiteCheckoutAutoCheck syspref Test plan: 1) Do an on-site checkout by clicking on checkbox and see date added 2) Unchecked and see that the date remains on input 3) Do another test with OnSiteCheckoutAutoCheck enabled 4) Apply this patch and repeat actions Normally now its works correctly Signed-off-by: tuxayo <victor@tuxayo.net>
It work :)
Created attachment 163692 [details] [review] Bug 18885: Specify due date behavior according to on-site checkbox When a on-site checkout is performed a date is automatically added but if you unchecked the date remains. Even with OnSiteCheckoutAutoCheck syspref Test plan: 1) Do an on-site checkout by clicking on checkbox and see date added 2) Unchecked and see that the date remains on input 3) Do another test with OnSiteCheckoutAutoCheck enabled 4) Apply this patch and repeat actions Normally now its works correctly Signed-off-by: tuxayo <victor@tuxayo.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Won't backport this to 23.05.x unless a fix for Bug 36459 is provided.
(In reply to Lucas Gass from comment #9) > Won't backport this to 23.05.x unless a fix for Bug 36459 is provided. I provided a patch for Bug 36459 if anyone wants to test.