|
Description
Jonathan Druart
2017-07-12 18:09:31 UTC
Created attachment 65010 [details] [review] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Created attachment 65157 [details] [review] [16.05.x] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI Looks good at a glance. I'll take another look at this once I've reviewed the other related bugs. Looks like I need to attend to other things at the moment, but I was just thinking... could you actually put this check into a module instead of on the about.pl page? That way, administrators on the server could perhaps run a script to check all their Koha instances for this data problem easily and quickly? Good morning I tried to apply this patch but get this error CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Failed to merge in the changes. Patch failed at 0001 Bug 18931: Add a "data corrupted" section on the about page - MySQL AI The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/1605x-Bug-18931-Add-a-data-corrupted-section-on-th-WHdTUz.patch Created attachment 65188 [details] [review] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 65189 [details] [review] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> My only suggestion is maybe it should stand out more? Maybe giant, red and blinking? First patch applies nicely for me on 16.11.x. Created attachment 65209 [details] [review] Bug 18931: Add items/deleteditems tables Created attachment 65210 [details] [review] [SIGNED OFF] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 65211 [details] [review] [SIGNED OFF] Bug 18931: Add items/deleteditems tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 65212 [details] [review] Bug 18931 - Follow up - Typo fix in SQL statement Fixes the table alias in the SQL statement for items and adds items to the if clause for showing data problems. Patches tested on 16.11.x successfully. Added a follow-up to fix some minor glitches. Created attachment 65255 [details] [review] [16.05.x] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 65256 [details] [review] Bug 18931: Add items/deleteditems tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 65257 [details] [review] Bug 18931 - Follow up - Typo fix in SQL statement Fixes the table alias in the SQL statement for items and adds items to the if clause for showing data problems. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 65258 [details] [review] Bug 18931: (followup) Tidy text Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 65259 [details] [review] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 65260 [details] [review] Bug 18931: (followup) Tidy text Some minor style and idiomatic issues. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 65266 [details] [review] Bug 18931 - Follow up - Typo fix in template for holds (In reply to Mason James from comment #21) > Created attachment 65266 [details] [review] [review] > Bug 18931 - Follow up - Typo fix in template for holds Ive tested this patchset on 16.05.x, it looks to be working well :) Created attachment 65267 [details]
pic
Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.02. Nice work. These patches have been pushed to 16.11.x and will be in 16.11.10. Created attachment 65299 [details] [review] Bug 18931: [QA Follow-up] Fix typo in closing p tag for items Close the p tag and add a br tag to visually divide the two sections Data problems and Warnings regarding system configuration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Discovered the problem when testing a duplicate key in deleteditems. Comment on attachment 65299 [details] [review] Bug 18931: [QA Follow-up] Fix typo in closing p tag for items Moved to bug 19000 Pushed to 16.05.x, for 16.05.15 release |