Summary: | Validation not being completed on member entry for number fields | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | katrin.fischer, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Bug 18932: Implementing rules for validating number fields for borrower info |
Description
Aleisha Amohia
2017-07-13 01:43:54 UTC
Created attachment 65013 [details] [review] Bug 18932: Implementing rules for validating number fields for borrower info The fields I've added validation for are (in both OPAC and staff client): - phone - secondary phone - other phone - fax - zipcode - alt address zipcode - alt address phone - alt contact zipcode - alt contact phone - SMS number (messaging preferences, may have to enable the EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC sysprefs to see this) To test: 1) In staff client, add a new patron or edit an existing one. Confirm that attempting to enter symbols or letters in the above fields prevents form submission 2) In OPAC, log in and edit your personal details. Confirm that attempting to enter symbols or letters in the above fields prevents form submission. 3) Go to your messaging preferences and confirm you can only save numbers in the SMS number field Sponsored-by: Catalyst IT Restriction to numbers only will lead to localization problems. For ZIP codes / postal codes: Some countries use alphanumeric codes https://en.wikipedia.org/wiki/Postal_code For phone numbers: It is no longer possible to enter an interntaional number starting with + https://en.wikipedia.org/wiki/List_of_country_calling_codes It is no longer possible to enter a formatted number, e.g. in Switzerland we often use +41 61 123 45 67 where +41 is the country code and 61 the area code I agree with Marc, this kind of very strict validation will probably cause more problems than help. We are also used to enter phone numbers with spaces for better readability, which is no longer possible with this patch. If this was implemented, it would cause a lot of errors every time an existing record is edited. Both fair comments, I did not think of those cases. I'll set this to Resolved - thanks for your input! Aleisha++ (In reply to Katrin Fischer from comment #5) > Aleisha++ +1 :-) |