Summary: | Cannot use internal login after ldap failure | ||
---|---|---|---|
Product: | Koha | Reporter: | Blou <philippe.blouin> |
Component: | Authentication | Assignee: | Bugs List <koha-bugs> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P3 | CC: | dpavlin, francois.charbonnier, jonathan.druart, jonathan.field, philippe.blouin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bug 18953 - Failure on alternate methods of login prevents validating values in DB |
Description
Blou
2017-07-18 19:55:50 UTC
Created attachment 65091 [details] [review] Bug 18953 - Failure on alternate methods of login prevents validating values in DB Normally, when failing to log using LDAP (because the user doesn't exist there, for example), the system will then check the credentials directly in the database. Recent changes in the code prevent that: a failure in LDAP will prevent internal credentials to be checked. This would also happen using CAS or Shibboleth. TO reproduce, you need to enable any of the method above, then try to connect using credentials that should succeed based on the info in your borrowers DB table but fail with the given method. Then apply the patch and try again. Hi, The patch won't apply. Looks like it needs a rebase as some other code has been added to Auth.pm in the meantime. If you can do that I can sign it off as we have a set-up just like this with LDAP running. Thanks You're absolutely correct, it is a duplicate. Well spotted! |