Bug 18953 - Cannot use internal login after ldap failure
Summary: Cannot use internal login after ldap failure
Status: RESOLVED DUPLICATE of bug 18880
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-18 19:55 UTC by Blou
Modified: 2017-07-31 19:45 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18953 - Failure on alternate methods of login prevents validating values in DB (1.34 KB, patch)
2017-07-18 20:03 UTC, Blou
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Blou 2017-07-18 19:55:50 UTC
When using LDAP (or cas or shiboleth), if the login fails using that method, the system doesn't check the internal user/pw anymore.  It just fails the login.
Comment 1 Blou 2017-07-18 20:03:19 UTC
Created attachment 65091 [details] [review]
Bug 18953 - Failure on alternate methods of login prevents validating values in DB

Normally, when failing to log using LDAP (because the user doesn't exist there, for example), the system
will then check the credentials directly in the database.  Recent changes in the code prevent that: a failure
in LDAP will prevent internal credentials to be checked.

This would also happen using CAS or Shibboleth.

TO reproduce, you need to enable any of the method above, then try to connect using credentials that should succeed
based on the info in your borrowers DB table but fail with the given method.  Then apply the patch and try again.
Comment 2 Jonathan Field 2017-07-26 10:47:28 UTC
Hi, The patch won't apply. Looks like it needs a rebase as some other code has been added to Auth.pm in the meantime. If you can do that I can sign it off as we have a set-up just like this with LDAP running. Thanks
Comment 3 Jonathan Druart 2017-07-26 16:59:22 UTC
Is this a duplicate of bug 18880?
Comment 4 Jonathan Field 2017-07-27 20:06:50 UTC
You're absolutely correct, it is a duplicate. Well spotted!
Comment 5 Jonathan Druart 2017-07-31 19:45:55 UTC

*** This bug has been marked as a duplicate of bug 18880 ***