Bug 19022

Summary: Improve location and author display in inventory tool
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: ToolsAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 19022 - inventory location and author display
Screenshot with patch
[SIGNED-OFF] Bug 19022 - inventory location and author display
Bug 19022 - inventory location and author display

Description Fridolin Somers 2017-08-02 08:41:58 UTC
In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.
Comment 1 Fridolin Somers 2017-08-02 08:52:02 UTC
Created attachment 65414 [details] [review]
Bug 19022 - inventory location and author display

In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.

This patch adds for location a span with class like in catalogue detail page, and changes author to be on same line in order to have a more compact display for this table that may be huge.

Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator
Comment 2 Fridolin Somers 2017-08-02 08:54:57 UTC
Created attachment 65415 [details]
Screenshot with patch
Comment 3 Owen Leonard 2017-08-02 13:40:54 UTC
Created attachment 65425 [details] [review]
[SIGNED-OFF] Bug 19022 - inventory location and author display

In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.

This patch adds for location a span with class like in catalogue detail page, and changes author to be on same line in order to have a more compact display for this table that may be huge.

Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Marcel de Rooy 2017-08-04 15:07:59 UTC
Fridolin: do not forget to add your name in Assignee field.
Comment 5 Fridolin Somers 2017-09-14 14:57:06 UTC
(In reply to Marcel de Rooy from comment #4)
> Fridolin: do not forget to add your name in Assignee field.

Oups forgotten thanks ;)

> Author is displayed into a paragraph making row hight.
Its high whithout t, I mean row is big.
Comment 6 Kyle M Hall (khall) 2017-10-27 14:53:19 UTC
Created attachment 68741 [details] [review]
Bug 19022 - inventory location and author display

In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.

This patch adds for location a span with class like in catalogue detail page, and changes author to be on same line in order to have a more compact display for this table that may be huge.

Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Jonathan Druart 2017-10-27 19:11:16 UTC
Pushed to master for 17.11, thanks to everybody involved!