Description
Tomás Cohen Arazi (tcohen)
2017-08-02 21:48:49 UTC
Created attachment 65480 [details] [review] Bug 19028: Add OPACLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OPACLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover Created attachment 65481 [details] [review] Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OPACLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OPACLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OPACLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes Created attachment 65516 [details] [review] Bug 19028: Add OpacLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover Created attachment 65517 [details] [review] Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OpacLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OpacLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes Created attachment 65565 [details] [review] [SIGNED-OFF] Bug 19028: Add OpacLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 65566 [details] [review] [SIGNED-OFF] Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OpacLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OpacLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 68466 [details] [review] Bug 19028: Add OpacLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 68467 [details] [review] Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OpacLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OpacLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Why do we have item_shelving_location hidden by default? If you set OpacLocationOnDetail="on a separate column", it will not be displayed. (In reply to Jonathan Druart from comment #9) > Why do we have item_shelving_location hidden by default? > If you set OpacLocationOnDetail="on a separate column", it will not be > displayed. The idea was to keep the current behaviour, plus adding the option to display on a separate column. What's missing on this patchset, is an explanation on the syspref description, stating that it is not enough to choose 'on a separate column', enabling the colum in the columns settings is required for it to take effect. Created attachment 68535 [details] [review] Bug 19028: Add a note to the pref description The idea was to keep the current behaviour, plus adding the option to display on a separate column. We need an explanation on the syspref description, stating that it is not enough to choose 'on a separate column', enabling the colum in the columns settings is required for it to take effect. Pushed to master for 17.11, thanks to everybody involved! |