Bug 19028 - Add 'shelving location' to holdings table in detail page
Summary: Add 'shelving location' to holdings table in detail page
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 16759
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-02 21:48 UTC by Tomás Cohen Arazi
Modified: 2017-10-25 15:19 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19028: Add OPACLocationOnDetail syspref (1.60 KB, patch)
2017-08-03 17:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 19028: Add 'shelving location' to holdings table in detail page (8.13 KB, patch)
2017-08-03 17:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 19028: Add OpacLocationOnDetail syspref (3.02 KB, patch)
2017-08-04 19:41 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 19028: Add 'shelving location' to holdings table in detail page (8.13 KB, patch)
2017-08-04 19:41 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 19028: Add OpacLocationOnDetail syspref (3.07 KB, patch)
2017-08-07 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 19028: Add 'shelving location' to holdings table in detail page (8.17 KB, patch)
2017-08-07 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19028: Add OpacLocationOnDetail syspref (3.11 KB, patch)
2017-10-24 13:35 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19028: Add 'shelving location' to holdings table in detail page (8.21 KB, patch)
2017-10-24 13:35 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19028: Add a note to the pref description (1.58 KB, patch)
2017-10-25 14:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2017-08-02 21:48:49 UTC
Bug 16759 adds a simpler way to customize what columns are displayed on the holdings table in the OPAC detail view.

It would be desired to allow moving the shelving location from below the library name, into its own column. This should be done in a way that preserves current behaviour. This can easily achieved by introducing a new syspref.
Comment 1 Tomás Cohen Arazi 2017-08-03 17:20:44 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2017-08-03 17:20:51 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2017-08-04 19:41:02 UTC
Created attachment 65516 [details] [review]
Bug 19028: Add OpacLocationOnDetail syspref

This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into
'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes
the OPAC display shelving location on a separate column, instead of the
library names (home, holding or both).

Sponsored-by: Dover
Comment 4 Tomás Cohen Arazi 2017-08-04 19:41:09 UTC
Created attachment 65517 [details] [review]
Bug 19028: Add 'shelving location' to holdings table in detail page

This patch adds the option to show shelving locations on a separate
column. This is controlled by a new syspref, 'OpacLocationOnDetail',
which replaces 'OpacLocationBranchToDisplayShelving', adding a
conveniente 'column' option.

The new 'Shelving location' column is conveniently added to the columns
configuration entry added by bug 16759 for this purpose.

The current behaviour is preserved.

To test:
- Apply this patches
- Run the upgrade:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ perl installer/data/mysql/updatedatabase.pl
=> SUCCESS: Upgrade doesn't fail
- Have an item with shelving location set to something not void
- Have the item set home and holding libraries for testing purposes.
- Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*]
- Visit the OPAC detail page for the record containing the item
=> SUCCESS: Both home and holding libraries are displayed.
- Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later).
=> SUCCESS: Works as expected.
- Go to Administration > Columns settings
- Make item_shelving_location available in the OPAC section
- Reload the OPAC detail page
=> SUCCESS: No change
- Set OpacLocationOnDetail to 'on a separate column'
- Reload the OPAC detail page
=> SUCCESS: Shelving location is displayed on a separate column
- Sign off :-D

Sponsored-by: Dover

[*] For testing purposes
Comment 5 Owen Leonard 2017-08-07 14:43:50 UTC
Created attachment 65565 [details] [review]
[SIGNED-OFF] Bug 19028: Add OpacLocationOnDetail syspref

This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into
'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes
the OPAC display shelving location on a separate column, instead of the
library names (home, holding or both).

Sponsored-by: Dover

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2017-08-07 14:43:53 UTC
Created attachment 65566 [details] [review]
[SIGNED-OFF] Bug 19028: Add 'shelving location' to holdings table in detail page

This patch adds the option to show shelving locations on a separate
column. This is controlled by a new syspref, 'OpacLocationOnDetail',
which replaces 'OpacLocationBranchToDisplayShelving', adding a
conveniente 'column' option.

The new 'Shelving location' column is conveniently added to the columns
configuration entry added by bug 16759 for this purpose.

The current behaviour is preserved.

To test:
- Apply this patches
- Run the upgrade:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ perl installer/data/mysql/updatedatabase.pl
=> SUCCESS: Upgrade doesn't fail
- Have an item with shelving location set to something not void
- Have the item set home and holding libraries for testing purposes.
- Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*]
- Visit the OPAC detail page for the record containing the item
=> SUCCESS: Both home and holding libraries are displayed.
- Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later).
=> SUCCESS: Works as expected.
- Go to Administration > Columns settings
- Make item_shelving_location available in the OPAC section
- Reload the OPAC detail page
=> SUCCESS: No change
- Set OpacLocationOnDetail to 'on a separate column'
- Reload the OPAC detail page
=> SUCCESS: Shelving location is displayed on a separate column
- Sign off :-D

Sponsored-by: Dover

[*] For testing purposes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Nick Clemens 2017-10-24 13:35:18 UTC
Created attachment 68466 [details] [review]
Bug 19028: Add OpacLocationOnDetail syspref

This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into
'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes
the OPAC display shelving location on a separate column, instead of the
library names (home, holding or both).

Sponsored-by: Dover

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens 2017-10-24 13:35:20 UTC
Created attachment 68467 [details] [review]
Bug 19028: Add 'shelving location' to holdings table in detail page

This patch adds the option to show shelving locations on a separate
column. This is controlled by a new syspref, 'OpacLocationOnDetail',
which replaces 'OpacLocationBranchToDisplayShelving', adding a
conveniente 'column' option.

The new 'Shelving location' column is conveniently added to the columns
configuration entry added by bug 16759 for this purpose.

The current behaviour is preserved.

To test:
- Apply this patches
- Run the upgrade:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ perl installer/data/mysql/updatedatabase.pl
=> SUCCESS: Upgrade doesn't fail
- Have an item with shelving location set to something not void
- Have the item set home and holding libraries for testing purposes.
- Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*]
- Visit the OPAC detail page for the record containing the item
=> SUCCESS: Both home and holding libraries are displayed.
- Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later).
=> SUCCESS: Works as expected.
- Go to Administration > Columns settings
- Make item_shelving_location available in the OPAC section
- Reload the OPAC detail page
=> SUCCESS: No change
- Set OpacLocationOnDetail to 'on a separate column'
- Reload the OPAC detail page
=> SUCCESS: Shelving location is displayed on a separate column
- Sign off :-D

Sponsored-by: Dover

[*] For testing purposes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Jonathan Druart 2017-10-24 18:14:46 UTC
Why do we have item_shelving_location hidden by default?
If you set OpacLocationOnDetail="on a separate column", it will not be displayed.
Comment 10 Tomás Cohen Arazi 2017-10-25 14:51:01 UTC
(In reply to Jonathan Druart from comment #9)
> Why do we have item_shelving_location hidden by default?
> If you set OpacLocationOnDetail="on a separate column", it will not be
> displayed.

The idea was to keep the current behaviour, plus adding the option to display on a separate column. What's missing on this patchset, is an explanation on the syspref description, stating that it is not enough to choose 'on a separate column', enabling the colum in the columns settings is required for it to take effect.
Comment 11 Jonathan Druart 2017-10-25 14:57:34 UTC
Created attachment 68535 [details] [review]
Bug 19028: Add a note to the pref description

The idea was to keep the current behaviour, plus adding the option to
display on a separate column.
We need an explanation on the syspref description, stating that it is not enough to
choose 'on a separate column', enabling the colum in the columns
settings is required for it to take effect.
Comment 12 Jonathan Druart 2017-10-25 15:19:09 UTC
Pushed to master for 17.11, thanks to everybody involved!