| Summary: | footerjs = 1 removed by bug 17855 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen, veron |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16058, 17418, 17855 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058
[SIGNED-OFF] Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 |
||
Created attachment 65538 [details] [review] Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Test plan: From the main page of the staff interface, delete a news item Without this patch applied you will not get a JS confirmation message Created attachment 65546 [details] [review] [SIGNED-OFF] Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Test plan: From the main page of the staff interface, delete a news item Without this patch applied you will not get a JS confirmation message Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 65548 [details] [review] Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Test plan: From the main page of the staff interface, delete a news item Without this patch applied you will not get a JS confirmation message Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Trivial fix. Pushed to master for 17.11, thanks to everybody involved! |
From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Reading the code I guess we lost the confirmation message when deleting a news item.