Summary: | Move C4::Reserves::GetReserve to the Koha namespace | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 19056 | ||
Bug Blocks: | 17728, 19058 | ||
Attachments: |
Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds
Bug 19057: Remove C4::Reserves::GetReserve Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds Bug 19057: Remove C4::Reserves::GetReserve Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds Bug 19057: Remove C4::Reserves::GetReserve |
Description
Jonathan Druart
2017-08-07 20:55:41 UTC
Created attachment 65612 [details] [review] Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds This GetReserve subroutine can be replaced with Koha::Holds->find Test plan: - git grep GetReserve must not return results where GetReserve is called - Cancel a reserve Created attachment 65613 [details] [review] Bug 19057: Remove C4::Reserves::GetReserve Created attachment 65618 [details] [review] Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds This GetReserve subroutine can be replaced with Koha::Holds->find Test plan: - git grep GetReserve must not return results where GetReserve is called - Cancel a reserve Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 65619 [details] [review] Bug 19057: Remove C4::Reserves::GetReserve Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 66775 [details] [review] Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds This GetReserve subroutine can be replaced with Koha::Holds->find Test plan: - git grep GetReserve must not return results where GetReserve is called - Cancel a reserve Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 66776 [details] [review] Bug 19057: Remove C4::Reserves::GetReserve Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. Oups mistake : Enhancement not pushed to 17.05.x |