GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects
Created attachment 65606 [details] [review] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve
t/db_dependent/Holds.t complains because of tests count (You planned 56 tests but ran 55).
Created attachment 65629 [details] [review] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve
Created attachment 65635 [details] [review] [SIGNED-OFF] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 66778 [details] [review] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x