| Summary: | Move C4::Reserves::GetReserveId to Koha::Holds | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Small patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 19057 | ||
| Bug Blocks: | 17728, 19059, 19766 | ||
| Attachments: |
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace [SIGNED-OFF] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace |
||
|
Description
Jonathan Druart
2017-08-07 21:01:32 UTC
Created attachment 65606 [details] [review] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve t/db_dependent/Holds.t complains because of tests count (You planned 56 tests but ran 55). Created attachment 65629 [details] [review] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve Created attachment 65635 [details] [review] [SIGNED-OFF] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 66778 [details] [review] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |