Bug 19062

Summary: Don't queue check-in/checkout messages if patron has no e-mail
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: NoticesAssignee: Bugs List <koha-bugs>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: aude.charillon, caroline.cyr-la-rose, hayleygpelham, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Katrin Fischer 2017-08-08 10:49:36 UTC
If the patron has no e-mail address we should not queue a check-in or checkout message.

If later on an e-mail address is added to the patron account all the old messages could be sent out by accident. Check out and check in messages are only interesting close to the checkout/checkin process, later on, they are just confusing to patrons.
Comment 1 Jonathan Druart 2017-10-10 14:08:34 UTC
Status is supposed to be set to 'failed' and so not resent later.
How could they be sent by accident?
Comment 2 Hayley Pelham 2019-04-30 22:51:57 UTC
Is this resolved?
Comment 3 Katrin Fischer 2023-02-26 12:53:57 UTC
They are still added as pending, being moved to 'failed' when the message queue is processed. 

Still wondering if this makes sense?
Comment 4 Jonathan Druart 2023-02-28 07:51:58 UTC
This is the expected behaviour in my understanding. You could add an email later and resend the message for instance.
Comment 5 Katrin Fischer 2023-02-28 08:31:25 UTC
(In reply to Jonathan Druart from comment #4)
> This is the expected behaviour in my understanding. You could add an email
> later and resend the message for instance.

Would be good to get some more opinions here, I am actually not sure what the expected behavior is. At least we are not consistent as other messages don't create a mail entry and fall back to print and others are not generated at all.
Comment 6 Katrin Fischer 2023-09-30 19:40:45 UTC
Would still be interesting to figure out if we consider this a bug or a feature :)
Comment 7 Caroline Cyr La Rose 2023-10-02 21:18:12 UTC
My understanding is the same as Jonathan's. If the patron has no address, when process_message_queue runs, it puts it as "failed", and adds a comment in the db ("NO_EMAIL").

After that, it is not treated again, unless we click on the resend button, or change it manually in the db back to "pending".
Comment 8 Katrin Fischer 2023-10-29 10:27:00 UTC
I am closing this WONTFIX then.