If the patron has no e-mail address we should not queue a check-in or checkout message. If later on an e-mail address is added to the patron account all the old messages could be sent out by accident. Check out and check in messages are only interesting close to the checkout/checkin process, later on, they are just confusing to patrons.
Status is supposed to be set to 'failed' and so not resent later. How could they be sent by accident?
Is this resolved?
They are still added as pending, being moved to 'failed' when the message queue is processed. Still wondering if this makes sense?
This is the expected behaviour in my understanding. You could add an email later and resend the message for instance.
(In reply to Jonathan Druart from comment #4) > This is the expected behaviour in my understanding. You could add an email > later and resend the message for instance. Would be good to get some more opinions here, I am actually not sure what the expected behavior is. At least we are not consistent as other messages don't create a mail entry and fall back to print and others are not generated at all.
Would still be interesting to figure out if we consider this a bug or a feature :)
My understanding is the same as Jonathan's. If the patron has no address, when process_message_queue runs, it puts it as "failed", and adds a comment in the db ("NO_EMAIL"). After that, it is not treated again, unless we click on the resend button, or change it manually in the db back to "pending".
I am closing this WONTFIX then.