Summary: | clubs/ is not correctly mapped in Makefile.PL | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | brendan, fridolin.somers, katrin.fischer, krishna.moorthy94, kyle, liz |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL
Bug 19067: Test Makefile.PL mapping [SIGNED OFF] Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL [SIGNED OFF] Bug 19067: Test Makefile.PL mapping Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL Bug 19067: Test Makefile.PL mapping |
Description
Tomás Cohen Arazi
2017-08-09 15:25:54 UTC
Created attachment 65762 [details] [review] Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D Created attachment 65765 [details] [review] Bug 19067: Test Makefile.PL mapping Created attachment 65774 [details] [review] [SIGNED OFF] Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I am upping severity - this bug means you can't use the hightlighted feature at all. Created attachment 65775 [details] [review] [SIGNED OFF] Bug 19067: Test Makefile.PL mapping Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 65813 [details] [review] Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 65814 [details] [review] Bug 19067: Test Makefile.PL mapping Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.04. No patron clubs in 16.11.x, so not needed there. *** Bug 19352 has been marked as a duplicate of this bug. *** Man it would have been nice if the symptom of this had been listed somewhere in the bug report. (In reply to Liz Rea from comment #12) > Man it would have been nice if the symptom of this had been listed somewhere > in the bug report. It would have been nice. Agreed |