Bug 19085

Summary: Empty files in English web installer
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Installation and upgrade (web-based installer)Assignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, jonathan.druart, m.de.rooy, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 5670    
Bug Blocks:    
Attachments: Bug 19085: Remove empty files patron_attributes.* in installer
Bug 19085: Remove empty files patron_attributes.* in installer
Bug 19085: Remove empty files patron_attributes.* in installer

Description Katrin Fischer 2017-08-11 09:52:39 UTC
The English web installer (maybe others too) contains 2 empty files:

- en/mandatory/patron_attributes.sql
- en/mandatory/patron_attributes.txt

It looks like the contents of the files might have been moved into optional.
Comment 1 Jonathan Druart 2017-10-10 12:49:14 UTC
Files added and emptied on bug 5670.
Comment 2 Jonathan Druart 2017-10-10 12:52:00 UTC
Created attachment 67869 [details] [review]
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.
Comment 3 Marc Véron 2017-10-11 08:34:30 UTC
Created attachment 67928 [details] [review]
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Marcel de Rooy 2017-10-11 11:52:12 UTC
Created attachment 67950 [details] [review]
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2017-10-11 16:54:07 UTC
Pushed to master for 17.11, thanks to everybody involved!