Summary: | Due to wrong variable name passed vendor name is not coming in browser title bar | ||
---|---|---|---|
Product: | Koha | Reporter: | Amit Gupta <amitddng135> |
Component: | Acquisitions | Assignee: | Amit Gupta <amitddng135> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | amit.gupta, amitddng135, fridolin.somers, jonathan.druart, katrin.fischer, mtj, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar
[SIGNED-OFF] Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar |
Description
Amit Gupta
2017-08-15 16:51:19 UTC
Passed wrong variable [% bookselname %] Created attachment 66029 [details] [review] Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar Test 1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx xx is a booksellerid 2. Apply the patch and reload the page. 3. You can see vendor name in browser title bar. This does fix the title bar. Though I was thinking of formatting. Should it be Vendor {name} without any punctuation? Perhaps it should have a colon or something, because Vendor is not part of the name, but the section we're in. Perhaps the › thing like Between Koha and Vendor? I'll sign off as is, and let QA comment further on that. Created attachment 66034 [details] [review] [SIGNED-OFF] Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar Test 1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx xx is a booksellerid 2. Apply the patch and reload the page. 3. You can see vendor name in browser title bar. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #3) > This does fix the title bar. > Though I was thinking of formatting. > Should it be Vendor {name} without any punctuation? > Perhaps it should have a colon or something, because Vendor is not part of > the name, but the section we're in. Perhaps the › thing like Between > Koha and Vendor? > I'll sign off as is, and let QA comment further on that. It follows the existing pattern. Created attachment 66485 [details] [review] Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar Test 1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx xx is a booksellerid 2. Apply the patch and reload the page. 3. You can see vendor name in browser title bar. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. This patch has been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |