When an open basket/order is closed, the breadcrumbs on the page asking about adding the order to a basket group is missing the vendor name in the breadcrumbs in 2 spots: Home › Acquisitions › › Basket Test bug 15347 (1) for
Created attachment 66517 [details] [review] Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT
*grumbles about having to set up budgets, funds, AND a vendor* ;) Before: Home › Acquisitions › › Basket test basket (1) for After: Home › Acquisitions › Test › Basket test basket (1) for Test Link works. :)
Created attachment 66562 [details] [review] Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
We are on basket.pl, sending a "name" variable to the template that is actually the "vendor name" can lead to issue. Let's rename it with "bookseller_name" or whatever more meaningful.
Created attachment 66603 [details] [review] Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT
Error message : fatal: sha1 information is lacking or useless (acqui/basket.pl).
Created attachment 67029 [details] [review] Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 67030 [details] [review] Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT
Created attachment 67031 [details] [review] Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT
Created attachment 67032 [details] [review] Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
(In reply to Caroline Cyr La Rose from comment #6) > Error message : > > fatal: sha1 information is lacking or useless (acqui/basket.pl). Because someone did a 'basketno | html' tweak to the template file. Easy enough to rebase and compare.
Created attachment 67156 [details] [review] Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 67213 [details] [review] Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 67214 [details] [review] Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
Doesn't apply cleanly to 16.11.x (second patch conflicts), please rebase if you want this to be included.
I checked - the bug exists in 16.11.x.