| Summary: | Script marc_subfields_structure ignores add/edit when liblibrarian is empty | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | MARC Bibliographic data support | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
I think we should remove it - I doubt that the current implementation is still working correctly and in use. Should we create an omnibus? I found a note in Auth.pm: # DEMO => the demo user is allowed to do everything (if demo set to 1 in koha.conf |
Around saving new or changed records in admin/marc_subfields_structure we have this construction: if (defined($liblibrarian) && $liblibrarian ne "") { my $is_demo = C4::Context->config('demo') || ''; if ( $is_demo ne '1' ) { So if you have no liblibrarian text or demo is set, your changes are lost. We could do better than that ! Note that the demo config variable is only used a couple of times in Koha in the context of changing biblio or auth fields and subfields. Do we need it ?