Bug 19131 - Script marc_subfields_structure ignores add/edit when liblibrarian is empty
Summary: Script marc_subfields_structure ignores add/edit when liblibrarian is empty
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-17 07:32 UTC by Marcel de Rooy
Modified: 2017-09-27 17:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2017-08-17 07:32:30 UTC
Around saving new or changed records in admin/marc_subfields_structure we have this construction:

if (defined($liblibrarian) && $liblibrarian ne "") {
            my $is_demo = C4::Context->config('demo') || '';
            if ( $is_demo ne '1' ) {

So if you have no liblibrarian text or demo is set, your changes are lost.
We could do better than that !

Note that the demo config variable is only used a couple of times in Koha in the context of changing biblio or auth fields and subfields. Do we need it ?
Comment 1 Katrin Fischer 2017-08-17 13:53:00 UTC
I think we should remove it - I doubt that the current implementation is still working correctly and in use. Should we create an omnibus?

I found a note in Auth.pm:
# DEMO => the demo user is allowed to do everything (if demo set to 1 in koha.conf