Bug 19186

Summary: SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode'
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: System AdministrationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Julian Maurice <julian.maurice>
Severity: trivial    
Priority: P5 - low CC: david.bourgault, gmcharlt, jonathan.druart, julian.maurice
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber
Bug 19186: (QA follow-up) Insert syspref SelfCheckoutByLogin if missing

Description Katrin Fischer 2017-08-27 11:14:58 UTC
The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes.
Comment 1 Jonathan Druart 2017-09-27 17:13:44 UTC
Created attachment 67406 [details] [review]
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber

The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be
Cardnumber. Especially since more and more libraries are using chip
cards instead of barcodes.
Comment 2 Jonathan Druart 2017-09-27 17:14:28 UTC
Note: this pref is not in sysprefs.sql (?)
Comment 3 David Bourgault 2017-09-29 19:27:24 UTC
Created attachment 67487 [details] [review]
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber

The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be
Cardnumber. Especially since more and more libraries are using chip
cards instead of barcodes.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 4 David Bourgault 2017-09-29 19:29:23 UTC
git grep SelfCheckoutByLogin found no SQL files or anything that looked like an insertion...
Comment 5 Julian Maurice 2017-10-13 13:35:11 UTC
Created attachment 68073 [details] [review]
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber

The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be
Cardnumber. Especially since more and more libraries are using chip
cards instead of barcodes.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Julian Maurice 2017-10-13 13:35:15 UTC
Created attachment 68074 [details] [review]
Bug 19186: (QA follow-up) Insert syspref SelfCheckoutByLogin if missing

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 7 Jonathan Druart 2017-10-13 17:00:37 UTC
Pushed to master for 17.11, thanks to everybody involved!