Bug 19186 - SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode'
Summary: SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode'
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jonathan Druart
QA Contact: Julian Maurice
URL:
Whiteboard:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2017-08-27 11:14 UTC by Katrin Fischer
Modified: 2017-10-13 17:00 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber (1.26 KB, patch)
2017-09-27 17:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber (1.31 KB, patch)
2017-09-29 19:27 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber (1.38 KB, patch)
2017-10-13 13:35 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 19186: (QA follow-up) Insert syspref SelfCheckoutByLogin if missing (2.42 KB, patch)
2017-10-13 13:35 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-08-27 11:14:58 UTC
The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes.
Comment 1 Jonathan Druart 2017-09-27 17:13:44 UTC
Created attachment 67406 [details] [review]
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber

The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be
Cardnumber. Especially since more and more libraries are using chip
cards instead of barcodes.
Comment 2 Jonathan Druart 2017-09-27 17:14:28 UTC
Note: this pref is not in sysprefs.sql (?)
Comment 3 David Bourgault 2017-09-29 19:27:24 UTC
Created attachment 67487 [details] [review]
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber

The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be
Cardnumber. Especially since more and more libraries are using chip
cards instead of barcodes.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 4 David Bourgault 2017-09-29 19:29:23 UTC
git grep SelfCheckoutByLogin found no SQL files or anything that looked like an insertion...
Comment 5 Julian Maurice 2017-10-13 13:35:11 UTC
Created attachment 68073 [details] [review]
Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber

The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be
Cardnumber. Especially since more and more libraries are using chip
cards instead of barcodes.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Julian Maurice 2017-10-13 13:35:15 UTC
Created attachment 68074 [details] [review]
Bug 19186: (QA follow-up) Insert syspref SelfCheckoutByLogin if missing

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 7 Jonathan Druart 2017-10-13 17:00:37 UTC
Pushed to master for 17.11, thanks to everybody involved!