Bug 19205

Summary: Pay selected fine generates 500 error
Product: Koha Reporter: Andreas Hedström Mace <andreas.hedstrom.mace>
Component: CirculationAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: critical    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, kyle
Version: master   
Target Milestone: Oldversions   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: Trivial patch
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Bug Depends on: 15908    
Bug Blocks: 19208    
Attachments: Bug 19205 - Pay selected fine generates 500 error
Bug 19205 - Pay selected fine generates 500 error
Bug 19205 - Pay selected fine generates 500 error

Description Andreas Hedström Mace 2017-08-30 13:34:56 UTC
Using the pay selected option from the borrowers account, to pay for one specific fine among other gives a 500 error, despite the payment going through.

To reproduce:
Add two fines using the Create manual invoice function.
Select one fine and "pay selected".
Pay a part of the amount.
Comment 1 Kyle M Hall 2017-08-30 13:39:05 UTC
Created attachment 66612 [details] [review]
Bug 19205 - Pay selected fine generates 500 error

Using the pay selected option from the borrowers account, to pay for one specific fine among other gives a 500 error, despite the payment going through.

Test Plan:
1) Add two fines using the Create manual invoice function.
2) Select one fine and "pay selected".
3) Pay a part of the amount.
4) Note error
5) Apply this patch
6) Repeat steps 1-3
7) No error!
Comment 2 Andreas Hedström Mace 2017-08-30 14:00:49 UTC
Created attachment 66614 [details] [review]
Bug 19205 - Pay selected fine generates 500 error

Using the pay selected option from the borrowers account, to pay for one specific fine among other gives a 500 error, despite the payment going through.

Test Plan:
1) Add two fines using the Create manual invoice function.
2) Select one fine and "pay selected".
3) Pay a part of the amount.
4) Note error
5) Apply this patch
6) Repeat steps 1-3
7) No error!

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Comment 3 Jonathan Druart 2017-08-30 14:46:34 UTC
Created attachment 66619 [details] [review]
Bug 19205 - Pay selected fine generates 500 error

Using the pay selected option from the borrowers account, to pay for one specific fine among other gives a 500 error, despite the payment going through.

Test Plan:
1) Add two fines using the Create manual invoice function.
2) Select one fine and "pay selected".
3) Pay a part of the amount.
4) Note error
5) Apply this patch
6) Repeat steps 1-3
7) No error!

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2017-08-30 20:02:50 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin SOMERS 2017-09-12 14:22:55 UTC
Pushed to 17.05.x, will be in 17.05.04.
Comment 6 Katrin Fischer 2017-09-15 22:47:56 UTC
I can't reproduce the error in 16.11.x and bug 15908 this depends on is not in 16.11.x.