|
Description
Marcel de Rooy
2017-09-05 12:45:34 UTC
Created attachment 66853 [details] [review] Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I was wondering if you could fix some other grammar while you are at it too. "Once the list is saved it will accessible" it will BE accessible. Created attachment 66868 [details] [review] Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 66889 [details] [review] Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 66890 [details] [review] Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Thanks for the followup addressing comment #2, Marcel. Created attachment 67759 [details] [review] Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 67760 [details] [review] Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 67761 [details] [review] Bug 19255: QA Followup - Fix tabs for spaces Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! |