Bug 19255 - Correct explanation about list categories on shelves.pl in staff
Summary: Correct explanation about list categories on shelves.pl in staff
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 18980
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-05 12:45 UTC by Marcel de Rooy
Modified: 2017-10-09 19:19 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19255: Correct explanation about list types on shelves.pl in staff (3.96 KB, patch)
2017-09-05 13:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19255: [Follow-up] Typo "will accessible" (1.13 KB, patch)
2017-09-06 11:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19255: Correct explanation about list types on shelves.pl in staff (3.98 KB, patch)
2017-09-06 16:10 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug 19255: [Follow-up] Typo "will accessible" (1.14 KB, patch)
2017-09-06 16:10 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug 19255: Correct explanation about list types on shelves.pl in staff (4.03 KB, patch)
2017-10-07 00:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19255: [Follow-up] Typo "will accessible" (1.20 KB, patch)
2017-10-07 00:09 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19255: QA Followup - Fix tabs for spaces (1.82 KB, patch)
2017-10-07 00:09 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2017-09-05 12:45:34 UTC
From Jonathan on bug 18980:
On the staff interface:
"""
    Private list: Is managed by you and can be seen only by you.
    Public list: Can be seen by everybody, but managed only by you.
"""

Should not we update it? If a list is private but shared, the description is wrong.
Comment 1 Marcel de Rooy 2017-09-05 13:49:07 UTC
Created attachment 66853 [details] [review]
Bug 19255: Correct explanation about list types on shelves.pl in staff

The explanation on list categories on the shelves form is removed.
The online help text is actualized.

Test plan:
Go to Lists in staff. Edit a list. The remarks about private and public
lists on the right side are gone.
Click Help. Read the adjusted text. Does it make sense?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 M. Tompsett 2017-09-06 04:44:17 UTC
I was wondering if you could fix some other grammar while you are at it too.
"Once the list is saved it will accessible"
it will BE accessible.
Comment 3 Marcel de Rooy 2017-09-06 11:02:41 UTC
Created attachment 66868 [details] [review]
Bug 19255: [Follow-up] Typo "will accessible"

This patch speaks for itself.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 M. Tompsett 2017-09-06 16:10:21 UTC
Created attachment 66889 [details] [review]
Bug 19255: Correct explanation about list types on shelves.pl in staff

The explanation on list categories on the shelves form is removed.
The online help text is actualized.

Test plan:
Go to Lists in staff. Edit a list. The remarks about private and public
lists on the right side are gone.
Click Help. Read the adjusted text. Does it make sense?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 5 M. Tompsett 2017-09-06 16:10:27 UTC
Created attachment 66890 [details] [review]
Bug 19255: [Follow-up] Typo "will accessible"

This patch speaks for itself.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 6 M. Tompsett 2017-09-06 16:12:49 UTC
Thanks for the followup addressing comment #2, Marcel.
Comment 7 Nick Clemens 2017-10-07 00:08:58 UTC
Created attachment 67759 [details] [review]
Bug 19255: Correct explanation about list types on shelves.pl in staff

The explanation on list categories on the shelves form is removed.
The online help text is actualized.

Test plan:
Go to Lists in staff. Edit a list. The remarks about private and public
lists on the right side are gone.
Click Help. Read the adjusted text. Does it make sense?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens 2017-10-07 00:09:00 UTC
Created attachment 67760 [details] [review]
Bug 19255: [Follow-up] Typo "will accessible"

This patch speaks for itself.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Nick Clemens 2017-10-07 00:09:03 UTC
Created attachment 67761 [details] [review]
Bug 19255: QA Followup - Fix tabs for spaces

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Jonathan Druart 2017-10-09 19:19:02 UTC
Pushed to master for 17.11, thanks to everybody involved!