Bug 19273

Summary: Confirm hold does not work for in-transit holds
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: CirculationAssignee: Kyle M Hall (khall) <kyle>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: dcook, gmcharlt, josef.moravec, kyle.m.hall, mishravk79
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 19273 - Confirm hold does not work for in-transit holds

Description Kyle M Hall (khall) 2017-09-07 12:57:04 UTC
If a hold was transferred to another library and that library uses the "Confirm" button instead of the "Print and confirm" button, the hold will remain "in transit" and will not be marked as waiting. The patron will also not receive notification of the hold since it never gets marked as waiting.
Comment 1 Kyle M Hall (khall) 2017-09-07 13:00:23 UTC
Created attachment 66933 [details] [review]
Bug 19273 - Confirm hold does not work for in-transit holds

If a hold was transferred to another library and that library
uses the "Confirm" button instead of the "Print and confirm" button,
the hold will remain "in transit" and will not be marked as waiting.

The patron will also not receive notification of the hold since it
never gets marked as waiting.

Test Plan:
1) Place a hold at Library A for pickup at Library B
2) Check the item in at Library A, confirm the transfer to Library B
3) Change your logged in branch to Library B
4) Check the item in at Library B
5) Confirm the hold using the "Confirm" button
6) Note the hold is still marked as in transit
7) Apply this patch
8) Repeat steps 1-5
9) Note the hold is marked correctly as waiting when the "Confirm"
   button is used
Comment 2 Katrin Fischer 2017-09-07 17:36:13 UTC
This is a duplicate to 19116. Very different fix - Kyle and Joseph, can you please take a look?
Comment 3 Katrin Fischer 2017-09-07 17:36:22 UTC

*** This bug has been marked as a duplicate of bug 19116 ***
Comment 4 Owen Leonard 2017-09-20 12:37:21 UTC
*** Bug 19346 has been marked as a duplicate of this bug. ***
Comment 5 David Cook 2018-05-08 01:40:22 UTC
I think that this is actually the right fix, but... curious to hear what others have to say.