If a hold was transferred to another library and that library uses the "Confirm" button instead of the "Print and confirm" button, the hold will remain "in transit" and will not be marked as waiting. The patron will also not receive notification of the hold since it never gets marked as waiting.
Created attachment 66933 [details] [review] Bug 19273 - Confirm hold does not work for in-transit holds If a hold was transferred to another library and that library uses the "Confirm" button instead of the "Print and confirm" button, the hold will remain "in transit" and will not be marked as waiting. The patron will also not receive notification of the hold since it never gets marked as waiting. Test Plan: 1) Place a hold at Library A for pickup at Library B 2) Check the item in at Library A, confirm the transfer to Library B 3) Change your logged in branch to Library B 4) Check the item in at Library B 5) Confirm the hold using the "Confirm" button 6) Note the hold is still marked as in transit 7) Apply this patch 8) Repeat steps 1-5 9) Note the hold is marked correctly as waiting when the "Confirm" button is used
This is a duplicate to 19116. Very different fix - Kyle and Joseph, can you please take a look?
*** This bug has been marked as a duplicate of bug 19116 ***
*** Bug 19346 has been marked as a duplicate of this bug. ***
I think that this is actually the right fix, but... curious to hear what others have to say.