Summary: | CanBookBeIssued: unsuccessfully refers to borrower category_type X | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17829 | ||
Bug Blocks: | 19280 | ||
Attachments: |
Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour
Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour Bug 19276: Update the number of tests |
Description
Marcel de Rooy
2017-09-08 09:08:49 UTC
Found while testing 15438 This may have bad side-effects. Created attachment 66997 [details] [review] Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour Bug 17829 must have been handle this specific case: GetMember set category_type, but now $borrower is a Koha::Patron unblessed and does not contain the category_type. The fix is to call ->category->category_type on the Koha::Patron object to be able to know if they are a statistic patrons. Test plan: Run the tests Lowering the severity, it's not in stable releases Created attachment 67028 [details] [review] Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour Bug 17829 must have been handle this specific case: GetMember set category_type, but now $borrower is a Koha::Patron unblessed and does not contain the category_type. The fix is to call ->category->category_type on the Koha::Patron object to be able to know if they are a statistic patrons. Test plan: Run the tests Tests pass, as does QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 67445 [details] [review] Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour Bug 17829 must have been handle this specific case: GetMember set category_type, but now $borrower is a Koha::Patron unblessed and does not contain the category_type. The fix is to call ->category->category_type on the Koha::Patron object to be able to know if they are a statistic patrons. Test plan: Run the tests Tests pass, as does QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Created attachment 67491 [details] [review] Bug 19276: Update the number of tests (In reply to Jonathan Druart from comment #8) > Created attachment 67491 [details] [review] [review] > Bug 19276: Update the number of tests Pushed to master! Depends on Bug 17829 that is not in 17.05.x |