Summary: | Error when submitting biblionumbers to batch record modification | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/tools/batch_record_modification.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 18260 | ||
Bug Blocks: | |||
Attachments: |
Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes
[SIGNED-OFF] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes |
Description
Owen Leonard
2017-09-21 14:04:02 UTC
Caused by commit c73e269a13f64fe016dc90941280c9d2e9cfb02c Bug 18260: Koha::Biblio - Remove GetBiblio Created attachment 67279 [details] [review] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Note that this patch can be backported, but I prefer to keep the dependency with bug 18260. Created attachment 67280 [details] [review] [SIGNED-OFF] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 67438 [details] [review] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 17.11, thanks to everybody involved! |