Summary: | Don't offer search option for libary groups when no groups are defined | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Searching | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15295 | ||
Bug Blocks: | |||
Attachments: |
Bug 19389: Hide library groups pull down if empty
Bug 19389: Hide library groups pull down if empty Bug 19389: Hide library groups pull down if empty |
Description
Katrin Fischer
2017-09-29 15:35:25 UTC
Created attachment 67528 [details] [review] Bug 19389: Hide library groups pull down if empty Regression introduced by bug commit 141200794da9f27e0231e1c2dad4bcb994d650f3 Bug 15295: Koha::Libraries - Remove GetBranchCategories The intranet advanced search page offers to search for groups of libraries, even if the pull down is empty as no library groups have been defined. Test plan: - Go to the adv search page at the intranet - Without library group you must not see the "Groups of libraries" dropdown list - With at least a library group you must see it Created attachment 67534 [details] [review] Bug 19389: Hide library groups pull down if empty Regression introduced by bug commit 141200794da9f27e0231e1c2dad4bcb994d650f3 Bug 15295: Koha::Libraries - Remove GetBranchCategories The intranet advanced search page offers to search for groups of libraries, even if the pull down is empty as no library groups have been defined. Test plan: - Go to the adv search page at the intranet - Without library group you must not see the "Groups of libraries" dropdown list - With at least a library group you must see it Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 68687 [details] [review] Bug 19389: Hide library groups pull down if empty Regression introduced by bug commit 141200794da9f27e0231e1c2dad4bcb994d650f3 Bug 15295: Koha::Libraries - Remove GetBranchCategories The intranet advanced search page offers to search for groups of libraries, even if the pull down is empty as no library groups have been defined. Test plan: - Go to the adv search page at the intranet - Without library group you must not see the "Groups of libraries" dropdown list - With at least a library group you must see it Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! |