Bug 19389 - Don't offer search option for libary groups when no groups are defined
Summary: Don't offer search option for libary groups when no groups are defined
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Kyle M Hall
URL:
Whiteboard:
Keywords:
Depends on: 15295
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-29 15:35 UTC by Katrin Fischer
Modified: 2017-10-27 17:16 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19389: Hide library groups pull down if empty (1.69 KB, patch)
2017-10-02 17:32 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 19389: Hide library groups pull down if empty (1.74 KB, patch)
2017-10-02 23:17 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19389: Hide library groups pull down if empty (1.80 KB, patch)
2017-10-27 12:41 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-09-29 15:35:25 UTC
The intranet advanced search page offers to search for groups of libraries, even if the pull down is empty as no library groups have been defined. 

It would be nicer to hide this search option when no groups are defined.
Comment 1 Jonathan Druart 2017-10-02 17:30:40 UTC
Regression introduced by bug 15295.
Comment 2 Jonathan Druart 2017-10-02 17:32:42 UTC
Created attachment 67528 [details] [review]
Bug 19389: Hide library groups pull down if empty

Regression introduced by bug
  commit 141200794da9f27e0231e1c2dad4bcb994d650f3
    Bug 15295: Koha::Libraries - Remove GetBranchCategories

The intranet advanced search page offers to search for groups of
libraries, even if the pull down is empty as no library groups have
been defined.

Test plan:
- Go to the adv search page at the intranet
- Without library group you must not see the "Groups of libraries"
dropdown list
- With at least a library group you must see it
Comment 3 Katrin Fischer 2017-10-02 23:17:10 UTC
Created attachment 67534 [details] [review]
Bug 19389: Hide library groups pull down if empty

Regression introduced by bug
  commit 141200794da9f27e0231e1c2dad4bcb994d650f3
    Bug 15295: Koha::Libraries - Remove GetBranchCategories

The intranet advanced search page offers to search for groups of
libraries, even if the pull down is empty as no library groups have
been defined.

Test plan:
- Go to the adv search page at the intranet
- Without library group you must not see the "Groups of libraries"
dropdown list
- With at least a library group you must see it

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2017-10-27 12:41:47 UTC
Created attachment 68687 [details] [review]
Bug 19389: Hide library groups pull down if empty

Regression introduced by bug
  commit 141200794da9f27e0231e1c2dad4bcb994d650f3
    Bug 15295: Koha::Libraries - Remove GetBranchCategories

The intranet advanced search page offers to search for groups of
libraries, even if the pull down is empty as no library groups have
been defined.

Test plan:
- Go to the adv search page at the intranet
- Without library group you must not see the "Groups of libraries"
dropdown list
- With at least a library group you must see it

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Jonathan Druart 2017-10-27 17:16:23 UTC
Pushed to master for 17.11, thanks to everybody involved!