Summary: | Move the location of the Ok and cancel buttons to the 008 cataloguing builder | ||
---|---|---|---|
Product: | Koha | Reporter: | Alex Buckley <alexbuckley> |
Component: | Cataloging | Assignee: | Alex Buckley <alexbuckley> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | katrin.fischer, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 19970 | ||
Attachments: |
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Bug 19413 - Followup Changed fieldset id value Bug 19413 - Followup Changed fieldset id value Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Bug 19413 - Followup Changed fieldset id value Screenshot of translated Plugin |
Description
Alex Buckley
2017-10-05 02:02:28 UTC
Created attachment 67623 [details] [review] Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Test plan: 1. Go into the Cataloguing module in the staff intranet 2. Create a new record in one of your MARC frameworks 3. Click on the small tag editor icon to the right of the 008 field 4. A new window (containing the 008 builder) will appear and notice that the OK and cancel buttons are at the bottom of the page in this window 5. Apply patch 6. Refresh this window (right click and select refresh button) 7. Notice that the OK and cancel buttons have moved to the top right of the page Sponsored-By: Catalyst IT Created attachment 67626 [details] [review] Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Followed test plan and patch applies and functions as described Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> I see that git grep "id=\"action\"" returns various results. Please explain why your change in staff-global would not have various side effects? Created attachment 67979 [details] [review] Bug 19413 - Followup Changed fieldset id value Sponsored-By: Catalyst IT Hi Marcel Apologies I made a mistake in not making the id value more specific. I have made the id value "fixedlengthbuilderaction" in the followup patch I have just attached to this bug report. Please test again Created attachment 67984 [details] [review] Bug 19413 - Followup Changed fieldset id value Followed test plan again and patch still applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Created attachment 68053 [details] [review] Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Followed test plan and patch applies and functions as described Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 68054 [details] [review] Bug 19413 - Followup Changed fieldset id value Followed test plan again and patch still applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Alex Buckley from comment #5) > Hi Marcel > > Apologies I made a mistake in not making the id value more specific. I have > made the id value "fixedlengthbuilderaction" in the followup patch I have > just attached to this bug report. Please test again Thx. Cool name ;) QA Comment: As mentioned in first comment, this will help librarians only adjusting information at the top of the form. Sounds reasonable. On the other hand those librarians that need to adjust something too at the end will now complain :) Would be interesting to make it floating like the cataloguing editor itself? No blocker for me. Especially since hitting Enter here submits the form too.. Pushed to master for 17.11, thanks to everybody involved! Created attachment 70480 [details]
Screenshot of translated Plugin
This doesn't work so well with languages where the term "Cancel" is translated to a longer word.
|