Summary: | Patron search is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Alex Arnaud <alex.arnaud> |
Component: | Patrons | Assignee: | Alex Arnaud <alex.arnaud> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P1 - high | CC: | fridolin.somers, glasklas, gmcharlt, jonathan.druart, julian.maurice, katrin.fischer, kyle.m.hall, mtj, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 12833 | ||
Bug Blocks: | |||
Attachments: |
Bug 19418 - Fix patron search
Screenshot with frozen patron search "Processing" Bug 19418: (bug 12833 follow-up) Add missing use statement |
Description
Alex Arnaud
2017-10-05 15:26:53 UTC
Created attachment 67674 [details] [review] Bug 19418 - Fix patron search Patron search fail on calling svc/members/search. This script return a 500 error and the search stay on "Processing..." Test plan: - Enable ExtendedPatronAttributes system preference, - make a standard search (search fields), - check the search works and it doesn't stick on "Processing..." *** Bug 19172 has been marked as a duplicate of this bug. *** I am sorry Alex, but I don't see the problem on master. I've tried various searches. I've made sure that I have patron attributes configured, that it is marked searchable and that at least one of the patrons has it set. I can reproduce the problem on a fresh master (725a3022c9) Note that I'm *not* using Plack (maybe this makes a difference ?) Seems that some people can reproduce the bug. The patch is quite tiny and make sense (just add use C4::Members::Attributes qw(SearchIdMatchingAttribute)) This could be quickly QAed/Pushed? Created attachment 67864 [details]
Screenshot with frozen patron search "Processing"
Tested on current master with Plack. The problem seems to happen arbitrarily.
See screenshot attached.
Created attachment 67871 [details] [review] Bug 19418: (bug 12833 follow-up) Add missing use statement Patron search fail on calling svc/members/search. This script return a 500 error and the search stay on "Processing..." Test plan: - Enable ExtendedPatronAttributes system preference, - make a standard search (search fields), - check the search works and it doesn't stick on "Processing..." Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I do not recreate the issue, but the change make sense and the issue has been raised by several people Skipping QA step and pushing to master for 17.11. Pushed to 17.05.x, will be in 17.05.05. This patch has been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |