Description
Tomás Cohen Arazi (tcohen)
2017-10-13 18:49:23 UTC
Created attachment 68094 [details] [review] Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 68095 [details] [review] Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Hi Tomas, Patch doesn't apply because it contain conflict in debian/scripts/koha-create Thanks. Bouzid. Created attachment 73953 [details] [review] Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 73954 [details] [review] Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Also, please amend the test plan to include: kshell kohadev prove -v xt/verify-debian-docbook.t -- koha-create will have passed. Created attachment 80748 [details] [review] Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 80749 [details] [review] Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 90074 [details] [review] Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Created attachment 96046 [details] [review] Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 96047 [details] [review] Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.02 backported to 19.05.x for 19.05.07 |