Bug 19465 - Allow choosing Elasticsearch server on instance creation
Summary: Allow choosing Elasticsearch server on instance creation
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-13 18:49 UTC by Tomás Cohen Arazi
Modified: 2018-09-14 16:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19465: Add --elasticsearch-server option to koha-create (4.64 KB, patch)
2017-10-13 19:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 19465: Document koha-create --elasticsearch-server option switch (1.44 KB, patch)
2017-10-13 19:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 19465: Add --elasticsearch-server option to koha-create (4.72 KB, patch)
2018-04-10 15:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 19465: Document koha-create --elasticsearch-server option switch (1.44 KB, patch)
2018-04-10 15:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2017-10-13 18:49:23 UTC
An --elasticsearch-server option switch should be added to 'koha-create'.
Comment 1 Tomás Cohen Arazi 2017-10-13 19:05:15 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2017-10-13 19:05:21 UTC Comment hidden (obsolete)
Comment 3 Bouzid Fergani 2018-04-06 19:10:31 UTC
Hi Tomas,
Patch doesn't apply because it contain conflict in debian/scripts/koha-create
Thanks.
Bouzid.
Comment 4 Tomás Cohen Arazi 2018-04-10 15:29:41 UTC
Created attachment 73953 [details] [review]
Bug 19465: Add --elasticsearch-server option to koha-create

This patch adds the --elasticsearch-server option switch to koha-create.
It allows choosing a different Elasticsearch configuration. It defaults
to the current 'localhost:9200' value.

To test:
- Apply this patches
- Run:
  $ reset_all
  $ man koha-create
=> SUCCESS: The man page shows correct information about the added
option switch
- Run:
  $ sudo koha-create --create-db test
=> SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default
   value (i.e. the current behaviour is kept)
- Run:
  $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2
=> SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed
   value in the <elasticsearch><server> section.
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2018-04-10 15:29:46 UTC
Created attachment 73954 [details] [review]
Bug 19465: Document koha-create --elasticsearch-server option switch

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 M. Tompsett 2018-09-14 16:10:54 UTC
Also, please amend the test plan to include:
kshell kohadev
prove -v xt/verify-debian-docbook.t
-- koha-create will have passed.