Summary: | Odd number of elements in anonymous hash in svc/bib | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | normal | ||
Priority: | P5 - low | CC: | nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19536: Odd number of elements in anonymous hash in svc/bib
Bug 19536: Odd number of elements in anonymous hash in svc/bib Bug 19536: Odd number of elements in anonymous hash in svc/bib |
Description
Marcel de Rooy
2017-10-27 09:34:05 UTC
Created attachment 68673 [details] [review] Bug 19536: Odd number of elements in anonymous hash in svc/bib Resolve: Odd number of elements in anonymous hash at svc/bib line 69. Odd number of elements in anonymous hash at svc/bib line 118. You can see such warnings when testing the Rancor editor. Replacing url_param by param in fetch_bib since it is a GET call. Not sure about doing the same in update_bib since that is a POST. The scalar context will resolve the odd number warns. Adding a scalar in svc/new_bib too. Test plan: Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch. Created attachment 68800 [details] [review] Bug 19536: Odd number of elements in anonymous hash in svc/bib Resolve: Odd number of elements in anonymous hash at svc/bib line 69. Odd number of elements in anonymous hash at svc/bib line 118. You can see such warnings when testing the Rancor editor. Replacing url_param by param in fetch_bib since it is a GET call. Not sure about doing the same in update_bib since that is a POST. The scalar context will resolve the odd number warns. Adding a scalar in svc/new_bib too. Test plan: Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 69128 [details] [review] Bug 19536: Odd number of elements in anonymous hash in svc/bib Resolve: Odd number of elements in anonymous hash at svc/bib line 69. Odd number of elements in anonymous hash at svc/bib line 118. You can see such warnings when testing the Rancor editor. Replacing url_param by param in fetch_bib since it is a GET call. Not sure about doing the same in update_bib since that is a POST. The scalar context will resolve the odd number warns. Adding a scalar in svc/new_bib too. Test plan: Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! |