Summary: | Allow skipping of patrons with valid emails for Talking Tech | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | barbara.johnson, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19620: Allow skipping of patrons with valid emails for Talking Tech
Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Works as described. Thx. -Jesse Bug 19620: Allow skipping of patrons with valid emails for Talking Tech |
Description
Kyle M Hall (khall)
2017-11-13 16:25:26 UTC
Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Course of action: 1) Modify the TT outbound script a) Add new '--skip-patrons-with-email' flag b) Modify the script to only return overdues where C4::Members::GetFirstValidEmailAddress comes back false c) Modify C4::Members::GetFirstValidEmailAddress to accept an optional hashref of patron data to avoid the cost of a double lookup Created attachment 72376 [details] [review] Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! Created attachment 72377 [details] [review] Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! Created attachment 79113 [details] [review] Works as described. Thx. -Jesse Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Created attachment 79258 [details] [review] Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I did not test but changes make sense Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |