Bug 19638

Summary: False positives for 'Update SQL' button
Product: Koha Reporter: Nick Clemens <nick>
Component: ReportsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: normal    
Priority: P5 - low CC: barton, fridolin.somers, jonathan.druart, josef.moravec
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17196, 17898    
Bug Blocks:    
Attachments: Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Description Nick Clemens 2017-11-16 13:18:50 UTC
bug 17898 tries to help users identify reports affected by the move of marcxml to the biblio_metadata table, however, the auth_header table still uses the column name 'marcxml' and so reports as needing updated though it doesn't
Comment 1 Jonathan Druart 2017-12-04 18:42:39 UTC
Created attachment 69488 [details] [review]
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Bug 17898 tries to help users identify reports affected by the move of
marcxml to the biblio_metadata table, however, the auth_header table
still uses the column name 'marcxml' and so reports as needing updated
though it doesn't.

C4::Reports::Guided::convert_sql only converts if the sql query contain
biblioitems and marcxml.
We should use the same regexp in the controler script.

Test plan:
Use a sql report that use auth_header.marcxml (see
https://wiki.koha-community.org/wiki/SQL_Reports_Library)
After the this the report should not be longer marked as obsolete on the
report list view
Comment 2 Dilan Johnpullé 2017-12-05 05:36:37 UTC
Created attachment 69494 [details] [review]
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Replicated bug with the following SQL:
	select marcxml from auth_header;

Patch applied correctly and functioned as expected.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 3 Josef Moravec 2017-12-05 08:07:47 UTC
Created attachment 69495 [details] [review]
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Bug 17898 tries to help users identify reports affected by the move of marcxml to the biblio_metadata table, however, the auth_header table still uses the column name 'marcxml' and so reports as needing updated though it doesn't.

C4::Reports::Guided::convert_sql only converts if the sql query contain biblioitems and marcxml.
We should use the same regexp in the controler script.

Test plan:
Use a sql report that use auth_header.marcxml (see https://wiki.koha-community.org/wiki/SQL_Reports_Library)
After the this the report should not be longer marked as obsolete on the report list view

Replicated bug with the following SQL:
	select marcxml from auth_header;

Patch applied correctly and functioned as expected.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Jonathan Druart 2017-12-07 14:23:18 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2017-12-14 12:33:35 UTC
Pushed to stable for 17.11.01, awesome work all!
Comment 6 Fridolin Somers 2017-12-20 11:12:53 UTC
Pushed to 17.05.x, will be in v17.05.07
Comment 7 Jonathan Druart 2018-05-21 13:05:30 UTC
*** Bug 19583 has been marked as a duplicate of this bug. ***