Bug 19683

Summary: Export.pl does not populate the Authority Types dropdown correctly
Product: Koha Reporter: David Bourgault <david.bourgault>
Component: ToolsAssignee: David Bourgault <david.bourgault>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, m.de.rooy, nick, philippe.blouin
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15381    
Bug Blocks:    
Attachments: Bug 19683 - Unbless authority_types search results
Bug 19683 - Unbless authority_types search results
Bug 19683 - Fix authority types in tools/export template

Description David Bourgault 2017-11-22 19:33:44 UTC
When exporting Authorities, the authority_type dropdown that enables filtering displays a list of blank values.

To reproduce:
0) Tools > Export > Export authority records
1) Authority Types dropdown is empty (except for "-- All --")

I've experienced the bug on 16.05 and master
Comment 1 David Bourgault 2017-11-22 19:36:17 UTC
Created attachment 69291 [details] [review]
Bug 19683 - Unbless authority_types search results

Fixes the bug by unblessing the authority types search results, and correcting the variable names in the template.

To test:
0) Tools > Export > Export authority records
1) Authority Types dropdown is not empty
Comment 2 Claire Gravely 2017-11-23 10:00:50 UTC
Created attachment 69300 [details] [review]
Bug 19683 - Unbless authority_types search results

Fixes the bug by unblessing the authority types search results, and correcting the variable names in the template.

To test:
0) Tools > Export > Export authority records
1) Authority Types dropdown is not empty

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Marcel de Rooy 2017-11-24 08:23:26 UTC
Created attachment 69329 [details] [review]
Bug 19683 - Fix authority types in tools/export template

Fixes the bug by correcting the variable names in the template.

To test:
1) Tools > Export > Export authority records
2) Authority Types dropdown is not empty

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended: Changing the export script and unblessing is not needed.
Comment 4 Jonathan Druart 2017-11-29 17:00:52 UTC
Caused by commit 7283069a9d3b2ffb2edc31022d96bb4aea107098
Bug 15381: Remove getauthtypes and getauthtype
Comment 5 Jonathan Druart 2017-12-07 12:40:32 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2017-12-14 12:29:22 UTC
Pushed to stable for 17.11.01, awesome work all!
Comment 7 Fridolin Somers 2017-12-20 07:48:03 UTC
Pushed to 17.05.x, will be in v17.05.07