Bug 19683 - Export.pl does not populate the Authority Types dropdown correctly
Summary: Export.pl does not populate the Authority Types dropdown correctly
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: David Bourgault
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on: 15381
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-22 19:33 UTC by David Bourgault
Modified: 2017-12-07 12:40 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19683 - Unbless authority_types search results (1.94 KB, patch)
2017-11-22 19:36 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 19683 - Unbless authority_types search results (1.99 KB, patch)
2017-11-23 10:00 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 19683 - Fix authority types in tools/export template (1.49 KB, patch)
2017-11-24 08:23 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Bourgault 2017-11-22 19:33:44 UTC
When exporting Authorities, the authority_type dropdown that enables filtering displays a list of blank values.

To reproduce:
0) Tools > Export > Export authority records
1) Authority Types dropdown is empty (except for "-- All --")

I've experienced the bug on 16.05 and master
Comment 1 David Bourgault 2017-11-22 19:36:17 UTC
Created attachment 69291 [details] [review]
Bug 19683 - Unbless authority_types search results

Fixes the bug by unblessing the authority types search results, and correcting the variable names in the template.

To test:
0) Tools > Export > Export authority records
1) Authority Types dropdown is not empty
Comment 2 Claire Gravely 2017-11-23 10:00:50 UTC
Created attachment 69300 [details] [review]
Bug 19683 - Unbless authority_types search results

Fixes the bug by unblessing the authority types search results, and correcting the variable names in the template.

To test:
0) Tools > Export > Export authority records
1) Authority Types dropdown is not empty

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Marcel de Rooy 2017-11-24 08:23:26 UTC
Created attachment 69329 [details] [review]
Bug 19683 - Fix authority types in tools/export template

Fixes the bug by correcting the variable names in the template.

To test:
1) Tools > Export > Export authority records
2) Authority Types dropdown is not empty

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended: Changing the export script and unblessing is not needed.
Comment 4 Jonathan Druart 2017-11-29 17:00:52 UTC
Caused by commit 7283069a9d3b2ffb2edc31022d96bb4aea107098
Bug 15381: Remove getauthtypes and getauthtype
Comment 5 Jonathan Druart 2017-12-07 12:40:32 UTC
Pushed to master for 18.05, thanks to everybody involved!